Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please upgrade CMake to 3.28 #2587

Open
Mottl opened this issue Aug 15, 2024 · 7 comments
Open

Please upgrade CMake to 3.28 #2587

Mottl opened this issue Aug 15, 2024 · 7 comments

Comments

@Mottl
Copy link

Mottl commented Aug 15, 2024

Crate name

lightgbm3-sys

Build failure link

https://docs.rs/crate/lightgbm3-sys/1.0.5/builds/1324739

Additional details

lightgbm3-sys is a binding library to LightGBM, which uses CMake at least 3.28:
https://github.com/microsoft/LightGBM/blob/602528315c6d5e4ae1e8f5de106cf56cf5869b16/CMakeLists.txt#L26

Could you upgrade to 3.28+ as well?

@syphar
Copy link
Member

syphar commented Aug 15, 2024

We're using a docker container to build the docs.

You can add any ubuntu package to the package list and it would be used for new builds after the image is deployed.

See also https://docs.rs/about/builds

@syphar
Copy link
Member

syphar commented Aug 15, 2024

i didn't check details, right now we're on ubuntu jammy in that image,

not sure if the cmake version you would need is available in jammy?

@syphar
Copy link
Member

syphar commented Aug 15, 2024

Just checking, jammy doesn't have it, the next LTS (noble) has it.

An ubuntu release upgrade on the crates-build-env would then be the solution, though that's a bit of work.

For anyone that might take on the work, this is the PR from last time for reference: rust-lang/crates-build-env#120

@Mottl
Copy link
Author

Mottl commented Aug 16, 2024

Denis, thanks for the explanation!
I added CMake 3.30.2 to Dockerfiles. Please check it out:
rust-lang/crates-build-env#150

@syphar
Copy link
Member

syphar commented Aug 18, 2024

@Mottl

I'm sorry if I wasn't clear enough in my messages above.
Right now we only accept standard ubuntu packages into the builder image due to the maintenance / security burden.
So upgrading to the latest LTS is the way to solve this issue.

An alternative is to work on #315 (allow custom docker images), but my hunch is that upgrading the main build env is less work.

@Mottl
Copy link
Author

Mottl commented Aug 18, 2024

Okay, Denis, make sense. I will try to find time to upgrade Dockerfile to 24.04

@Mottl
Copy link
Author

Mottl commented Aug 21, 2024

This commit updates images to 24.04:
rust-lang/crates-build-env#151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants