-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please upgrade CMake to 3.28 #2587
Comments
We're using a docker container to build the docs. You can add any ubuntu package to the package list and it would be used for new builds after the image is deployed. See also https://docs.rs/about/builds |
i didn't check details, right now we're on ubuntu jammy in that image, not sure if the cmake version you would need is available in jammy? |
Just checking, jammy doesn't have it, the next LTS (noble) has it. An ubuntu release upgrade on the crates-build-env would then be the solution, though that's a bit of work. For anyone that might take on the work, this is the PR from last time for reference: rust-lang/crates-build-env#120 |
Denis, thanks for the explanation! |
I'm sorry if I wasn't clear enough in my messages above. An alternative is to work on #315 (allow custom docker images), but my hunch is that upgrading the main build env is less work. |
Okay, Denis, make sense. I will try to find time to upgrade Dockerfile to 24.04 |
This commit updates images to 24.04: |
Crate name
lightgbm3-sys
Build failure link
https://docs.rs/crate/lightgbm3-sys/1.0.5/builds/1324739
Additional details
lightgbm3-sys is a binding library to LightGBM, which uses CMake at least 3.28:
https://github.com/microsoft/LightGBM/blob/602528315c6d5e4ae1e8f5de106cf56cf5869b16/CMakeLists.txt#L26
Could you upgrade to 3.28+ as well?
The text was updated successfully, but these errors were encountered: