-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add advice for nightly usage #88
Comments
Yes please, I found this very confusing. I assumed that |
The README says: "An image tracking the Rust nightly toolchain is available via rustlang/rust:nightly." -- and has said so for the last 6 years. Is this sufficient advice, or do you think it should be mentioned somewhere else too? |
Yes... that's the problem. You only see that if you land on the README here on Github. No where on the DockerHub page for the official image does it mention anything about nightly toolchain (or the alternative image for it). Often Docker users will land on DockerHub when searching for an image, and rarely expect the documentation to differ in any meaningful way at the source (which is not always linked to). Meanwhile, the nightly image is clear that despite the image name, it's only focused on nightly builds, and references the reader to the official image for anything else. The official image should likewise link to the nightly image for those that need that.
I assume I did not see that, nor did the reporter of the issue I referenced 🤷♂️ Perhaps I landed on that issue directly via Google, I don't recall. Either way, requesting a mention on the DockerHub page still seems valid. |
Sorry, I re-read what I wrote a year ago and had no idea what I meant. But I think the issue/workflow was: let's say you come at this resource via working on CI. Your CI config has
You want to add nightly tests. You know the images follow the pattern Oh, there's no nightly there. But the image page says it's official, and maintained by the Rust project devs, which links to here. So I come here, I read the README. I see there's a Turns out, no! It's not! Where I came from was an official Docker image. This new thing ( These are the kinds of heuristics that go through my mind when I'm trying to make sure I don't accidentally use a malicious image for CI, or use an out-of-date image, etc. etc. Any little inconsistency is a red flag. And eventually, yes, going through the code and the docs confirms that this is indeed the "Rust official" image even if it's not a "Rust AND Docker official" image. But it could be clearer I think. Something like:
...or...
And then also maybe a liiiiitle more exposition on the Docker team and image pages? |
This is not covered on the DockerHub image page.
I came across this issue which mentions
rustlang/rust
and links to the official image. It would be nice to have a mention of preferring that image from the official one as well when interested in the nightly channel.The text was updated successfully, but these errors were encountered: