Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MpMcQueue drop implementation is not optimized #489

Open
sosthene-nitrokey opened this issue Jul 1, 2024 · 0 comments
Open

MpMcQueue drop implementation is not optimized #489

sosthene-nitrokey opened this issue Jul 1, 2024 · 0 comments
Labels
enhancement

Comments

@sosthene-nitrokey
Copy link
Contributor

The MpMcQueue  drop implementation is not optimized, as it uses the normal dequeue method, which assumes a shared reference and prevents race condition. drop gives us a mutable reference, which means that the implementation could skip the atomic operations, and all the care for synchronization.

See #483 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@newAM @sosthene-nitrokey