Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop-in replacement from facebook's Immutable.js? #213

Open
maxgalbu opened this issue Apr 4, 2017 · 3 comments
Open

Drop-in replacement from facebook's Immutable.js? #213

maxgalbu opened this issue Apr 4, 2017 · 3 comments

Comments

@maxgalbu
Copy link

maxgalbu commented Apr 4, 2017

Can this replace facebook's immutable library? We're experiencing some big cpu usage and garbage collector runs on our app, and we were trying to isolate the problem.

I'm not sure about the functionality, but from my quick test, it's missing two functions (I'm excluding fromJS because there's from()): toJS and get. Probably toJS() could be implemented simply with:

function toJS(obj) {
      return asDeepMutable(obj);
  }

I'm not sure about get()..

@srph
Copy link

srph commented Apr 5, 2017

Doesn't Immutable.asMutable(obj, {deep: true}) solve toJS?

@maxgalbu
Copy link
Author

maxgalbu commented Apr 5, 2017

Yep that's what I wrote before :)

@crudh
Copy link
Collaborator

crudh commented Sep 2, 2018

@maxgalbu late answer, but is getIn similar?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants