Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_connection_never_established wrong #55

Open
gabis-precog opened this issue Jun 21, 2022 · 5 comments
Open

test_connection_never_established wrong #55

gabis-precog opened this issue Jun 21, 2022 · 5 comments
Labels

Comments

@gabis-precog
Copy link
Collaborator

test_connection_never_established doesn't really attempt to reconnect 3 times and fail as specified.
only attempts connection once and then throws the expected exception (as visible in logs)

@KartikShrivastava
Copy link

Hi @gabis-precog, is this being actively worked upon, if not than can I work on this?

@jell-o-fishi
Copy link
Member

I actually haven't checked in a long time if this still happens. Go for it :)

@jell-o-fishi
Copy link
Member

I am unsure if this is an actual problem in the code or just in the way it is tested. The solution might be a different test.

@jell-o-fishi
Copy link
Member

@KartikShrivastava. upon further inspection, the test seems meaningless. if you really feel like doing something about , i suggest devising a proper way of testing entire reconnect mechanism, retry on disconnect, and on initial connect failure.

@KartikShrivastava
Copy link

KartikShrivastava commented Feb 19, 2024

Thanks for your inputs @jell-o-fishi, will continue in that direction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants