You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
However in the case of builders (where one doesn't really need to "get" values after setting them) the convention is typically flipped and you set values with methods that are rarely prefixed with set_.
Should we follow these guidelines in the case of Package even though it might potentially be easier to visually confuse with RpmPackageBuilder? (This is Rust, the type information isn't that far away, so it's not that big a deal).
currently methods on Package follow the following pattern (no setters):
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Standard Rust naming convention for getters is to exclude the
get_
prefix, e.g.See: https://rust-lang.github.io/api-guidelines/naming.html#getter-names-follow-rust-convention-c-getter
However in the case of builders (where one doesn't really need to "get" values after setting them) the convention is typically flipped and you set values with methods that are rarely prefixed with
set_
.Should we follow these guidelines in the case of
Package
even though it might potentially be easier to visually confuse withRpmPackageBuilder
? (This is Rust, the type information isn't that far away, so it's not that big a deal).currently methods on
Package
follow the following pattern (no setters):Beta Was this translation helpful? Give feedback.
All reactions