Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rooch-server] rooch server start should support custom RPC port #692

Closed
feliciss opened this issue Aug 24, 2023 · 1 comment · Fixed by #753
Closed

[rooch-server] rooch server start should support custom RPC port #692

feliciss opened this issue Aug 24, 2023 · 1 comment · Fixed by #753
Labels
feature New feature
Milestone

Comments

@feliciss
Copy link
Collaborator

feliciss commented Aug 24, 2023

The server config:

impl Default for ServerConfig {
    fn default() -> Self {
        Self {
            host: "0.0.0.0".to_string(),
            port: 50051,
            proposer_address: None,
            sequencer_address: None,
            block_propose_duration_in_seconds: 5,
        }
    }
}

Should support custom RPC port, like starting the server with a port from input rooch server start --port 50001 to test local PRC config via MetaMask as chain_id variable is added #681.

Otherwise, the newly added RPC config through rooch env add command cannot be tested with MetaMask for a chain_id:

envs:
- chain_id: 20230103
  alias: default
  rpc: http://0.0.0.0:50051
  ws: null
- chain_id: 2001
  alias: ROH
  rpc: http://0.0.0.0:50001
  ws: null
@feliciss
Copy link
Collaborator Author

Same as rooch init -s command that only inits one RPC config:

envs:
- chain_id: 2002
  alias: custom
  rpc: http://0.0.0.0:50055
  ws: null

@jolestar jolestar added this to the Rooch v0.2 milestone Aug 24, 2023
@jolestar jolestar added the feature New feature label Aug 24, 2023
@github-project-automation github-project-automation bot moved this to Done in Rooch Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants