Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about task and task embeddings #17

Open
yihangZhu1729 opened this issue Apr 1, 2024 · 1 comment
Open

Question about task and task embeddings #17

yihangZhu1729 opened this issue Apr 1, 2024 · 1 comment

Comments

@yihangZhu1729
Copy link

Thank you for your wonderful work and code release.
In the file constants.py, variables TASKS and corresponding TEXT_EMBEDDINGS are given. The correspondence has been checked using the link you gave in the same file. Here I have two questions.
(1) It seems that TASKS has redundent and totally same terms, shown in the following image.
image
(2) In the file utils.py where the variable TASKS is used, it seems that the text embedding does not match their actual task at all! For example, if close_drawer is in the filename, it will get the task embedding of "Slide open drawer from right to left"!
image
The mismatch makes me wonder if the FiLM condition in the network really works as expected.

Looking forward to your reply.

@Jdvakil
Copy link
Collaborator

Jdvakil commented Apr 2, 2024

Hi, thanks for reaching out! When we were training the agent, the TASKS and TEXT_EMBEDDINGS were the same names and count. The FiLM conditioning seemed to work during evaluations as in the same scene with different task combinations, we were able to solve a particular task with just text

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants