Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Talents in the PU3 library all include BOTH the reaction bonus and the alternate benifit bonus #312

Open
smithkm opened this issue Jul 27, 2024 · 1 comment

Comments

@smithkm
Copy link
Contributor

smithkm commented Jul 27, 2024

PU3 provides an alternative benefit for each talent to use instead of the reaction bonus. They used to be modifiers so they could be easily switched between. It looks like they have been moved to being features on the base trait which makes both show up. I expect this was done to allow them to include the level of the talent in their condition messages.

Either each talent needs to be included twice, once for reaction bonus and once for alternate benefit (A gcs_master_library) or we need a way to toggle between different features on a trait like we can modifiers, or the condition message for a modifier needs to be able to use the level of its parent trait instead of its own level. (Any of which would require a change upstream in GCS see richardwilkes/gcs#660)

dripton pushed a commit that referenced this issue Aug 5, 2024
* Resave power up traits

* Talent benefits as modifiers so reaction bonus and other benefits can be easily swapped out.
@richardwilkes richardwilkes self-assigned this Aug 16, 2024
@richardwilkes
Copy link
Owner

Does this still need some work (i.e. data file changes or code changes in GCS)?

@richardwilkes richardwilkes removed their assignment Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants