Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: bump ruff from 0.7.1 to 0.7.2 in /dockerfile #5978

Closed
wants to merge 2 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 4, 2024

Bumps ruff from 0.7.1 to 0.7.2.

Release notes

Sourced from ruff's releases.

0.7.2

Release Notes

Preview features

  • Fix formatting of single with-item with trailing comment (#14005)
  • [pyupgrade] Add PEP 646 Unpack conversion to * with fix (UP044) (#13988)

Rule changes

  • Regenerate known_stdlibs.rs with stdlibs 2024.10.25 (#13963)
  • [flake8-no-pep420] Skip namespace package enforcement for PEP 723 scripts (INP001) (#13974)

Server

  • Fix server panic when undoing an edit (#14010)

Bug fixes

  • Fix issues in discovering ruff in pip build environments (#13881)
  • [flake8-type-checking] Fix false positive for singledispatchmethod (TCH003) (#13941)
  • [flake8-type-checking] Treat return type of singledispatch as runtime-required (TCH003) (#13957)

Documentation

  • [flake8-simplify] Include caveats of enabling if-else-block-instead-of-if-exp (SIM108) (#14019)

Install ruff 0.7.2

Install prebuilt binaries via shell script

curl --proto '=https' --tlsv1.2 -LsSf https://github.com/astral-sh/ruff/releases/download/0.7.2/ruff-installer.sh | sh

Install prebuilt binaries via powershell script

powershell -ExecutionPolicy ByPass -c "irm https://github.com/astral-sh/ruff/releases/download/0.7.2/ruff-installer.ps1 | iex"

Download ruff 0.7.2

File Platform Checksum
ruff-aarch64-apple-darwin.tar.gz Apple Silicon macOS checksum
ruff-x86_64-apple-darwin.tar.gz Intel macOS checksum
ruff-aarch64-pc-windows-msvc.zip ARM64 Windows checksum
ruff-i686-pc-windows-msvc.zip x86 Windows checksum
ruff-x86_64-pc-windows-msvc.zip x64 Windows checksum

... (truncated)

Changelog

Sourced from ruff's changelog.

0.7.2

Preview features

  • Fix formatting of single with-item with trailing comment (#14005)
  • [pyupgrade] Add PEP 646 Unpack conversion to * with fix (UP044) (#13988)

Rule changes

  • Regenerate known_stdlibs.rs with stdlibs 2024.10.25 (#13963)
  • [flake8-no-pep420] Skip namespace package enforcement for PEP 723 scripts (INP001) (#13974)

Server

  • Fix server panic when undoing an edit (#14010)

Bug fixes

  • Fix issues in discovering ruff in pip build environments (#13881)
  • [flake8-type-checking] Fix false positive for singledispatchmethod (TCH003) (#13941)
  • [flake8-type-checking] Treat return type of singledispatch as runtime-required (TCH003) (#13957)

Documentation

  • [flake8-simplify] Include caveats of enabling if-else-block-instead-of-if-exp (SIM108) (#14019)
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added infrastructure Changes affecting mostly infrastructure sanity check required Only sanity checking needed if tests passed labels Nov 4, 2024
@github-actions github-actions bot added the f42 Fedora 42 label Nov 4, 2024
dependabot bot and others added 2 commits November 11, 2024 14:47
Bumps [ruff](https://github.com/astral-sh/ruff) from 0.7.1 to 0.7.2.
- [Release notes](https://github.com/astral-sh/ruff/releases)
- [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md)
- [Commits](astral-sh/ruff@0.7.1...0.7.2)

---
updated-dependencies:
- dependency-name: ruff
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
The C preprocessor and compiler handle macros differently than standard C syntax checks.
The macro expansion may have included the semicolon internally, making it optional at the
source code level. However, static analysis tools like Ruff might not expand macros,
leading to false positives.

This fixes the recent ruff check failure.
@KKoukiou KKoukiou force-pushed the dependabot/pip/dockerfile/ruff-0.7.2 branch from 2ac750f to b69f7ec Compare November 11, 2024 13:47
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 11, 2024

A newer version of ruff exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@KKoukiou
Copy link
Contributor

/kickstart-tests --waive infra only

@jkonecny12
Copy link
Member

Ruff is checking C files? I thought he is python specific.

Aren't you resolving the same issue as here #5985 ?

@KKoukiou
Copy link
Contributor

Ruff is checking C files? I thought he is python specific.

Aren't you resolving the same issue as here #5985 ?

yes sorry I got distracted. still I think we can revert these syntax error whitelisting. It's correct to add semicolon.

@KKoukiou KKoukiou closed this Nov 12, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 12, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/pip/dockerfile/ruff-0.7.2 branch November 12, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f42 Fedora 42 infrastructure Changes affecting mostly infrastructure sanity check required Only sanity checking needed if tests passed
Development

Successfully merging this pull request may close these issues.

2 participants