liveinst: Allow running as a Wayland-native application

[Conan-Kudo]

As long as we have the path to the Wayland socket, we can run Anaconda as a Wayland-native application.

[jkonecny12]

/kickstart-test --testtype smoke

[jkonecny12]

/build-image --live

[github-actions]

Images built based on commit 8c55c2f:

• Live: success

Download the images from the bottom of the job status page.

[jkonecny12]

/kickstart-test --testtype smoke

[jkonecny12]

/build-image --live

[github-actions]

Images built based on commit b7b5800:

• Live: success

Download the images from the bottom of the job status page.

[jkonecny12]

The shellcheck issues needs to be resolved first:

data/liveinst/liveinst:51:12: warning: Declare and assign separately to avoid masking return values. [SC2155]
data/liveinst/liveinst:55:22: note: Double quote to prevent globbing and word splitting. [SC2086]
data/liveinst/liveinst:56:8: warning: Declare and assign separately to avoid masking return values. [SC2155]

If you think this is fine to go, you can disable the checks with comment

# shellcheck disable=SC2155

[Conan-Kudo]

@jkonecny12 Done.

[jkonecny12]

/kickstart-test --testtype smoke

[jkonecny12]

/build-image --live

[github-actions]

Images built based on commit 900abc1:

• Live: success

Download the images from the bottom of the job status page.

[KKoukiou]

@Conan-Kudo have you maybe tested that on the non wayland spins as well?

[Conan-Kudo]

@Conan-Kudo have you maybe tested that on the non wayland spins as well?

Yes, I verified this changes none of the behavior on Fedora LXQt in X11 mode.

[jkonecny12]

Seems that this patch will break Fedora Workstation.

[jkonecny12]

I finally get to the retesting of your change and it doesn't return any error on the terminal. However, I was able to find:

anaconda: ui.webui: web-ui: the webui-desktop script ended abruptly!

[jkonecny12]

So there is more from the error:

and I was able to debug the fail to this line: https://github.com/rhinstaller/anaconda-webui/blob/main/webui-desktop#L102

and from the screenshot you should be able to see:

GLib.py:497: Warning: ../glib/gmain.c:5930: waitpid(pid:5154) failed: No child processes (10). See documentation of g_child_watch_source_new() for possible causes.

Not sure how this exactly related to systemd-cat call or why your changes are causing this issue.

[KKoukiou]

@Conan-Kudo the tried this as well with some extra debugging and I got:

Looks like this change has problem with Web UI firefox running as root. We are about to change that, #5689

So maybe we can re-try this PR after the rootless Web UI is active.

[KKoukiou]

Needs rebase.
Here is a rebased version https://github.com/KKoukiou/anaconda/tree/wayland-liveinst in case you dont have time to check.

thanks I will re-test after it's conflict free.

[Conan-Kudo]

I rebased this yesterday.

[KKoukiou]

For Workstation with Web UI it works fine. I did not test any non wayland spin.

[jkonecny12]

/build-image --live

[github-actions]

Images built based on commit 54a7098:

• Live: success

Download the images from the bottom of the job status page.

[jkonecny12]

/kickstart-test --testtype smoke

[jkonecny12]

/kickstart-test fedora-live-image-build

[jkonecny12]

I finally was able to get to this and it seems to be working correctly. Thanks for contribution!

[jkonecny12]

To be sure tested also on Xfce and works without any problem.