infra: tests: add rpmlint to existing rpm tests #5929
Conversation
github-actions
bot
added
infrastructure
elkoniu
force-pushed
the
add-rpmlint-to-ci
branch
from
e822c0c
to
f89375f
Compare
|
Infrastructure check failed on these files. Please do a double check of these files before merge! Makefile.am |
elkoniu
force-pushed
the
add-rpmlint-to-ci
branch
from
f89375f
to
9b7188e
Compare
|
Infrastructure check failed on these files. Please do a double check of these files before merge! Makefile.am |
elkoniu
force-pushed
the
add-rpmlint-to-ci
branch
from
9b7188e
to
fe2d34b
Compare
|
Infrastructure check failed on these files. Please do a double check of these files before merge! Makefile.am |
|
@KKoukiou I have update this PR so when |
|
I really like this idea. |
|
This will not fail after PRs introducing config file will be merged. |
Makefile.am
Outdated
| dnf install -y /tmp/anaconda/result/build/01-rpm-build/*.rpm; \ | ||
| cd /tmp/anaconda; \ | ||
| if [ -f rpmlint.toml ]; then LINT_ARG="--config rpmlint.toml"; else LINT_ARG=""; fi; \ | ||
| rpmlint *.spec.in result/build/01-rpm-build/*.rpm ${LINT_ARG}' |
There was a problem hiding this comment.
I think the better would solution would be to have this as script in the container. Let's try to avoid overloading of this command to avoid installation of the package to the host system because of issue in bash.
There was a problem hiding this comment.
You mean to have a separated script with the content rpmlint ..... an just call it from here? To be honest the part with if [ -f rpmlint.toml ] can be skipped as I assume the file will be always presented.
There was a problem hiding this comment.
I have updated the code so it just calls rpmlint with the config file and path we use for RPM storage.
elkoniu
force-pushed
the
add-rpmlint-to-ci
branch
from
fe2d34b
to
5e3ffbc
Compare
|
Infrastructure check failed on these files. Please do a double check of these files before merge! Makefile.am |
|
/kickstart-test --testtype smoke |
|
I wonder, do we need to install Anaconda packages? You are already giving RPMs and spec to the linter. Isn't that enough? |
I think it is happening because I have appended existing |
KKoukiou
force-pushed
the
add-rpmlint-to-ci
branch
from
5e3ffbc
to
04a27f5
Compare
KKoukiou
changed the title
rpmlint is used in Fedora dist git in the release process. Having it included in the upstream CI will enable early detection of the potential linter issues in spec / rpms.
KKoukiou
force-pushed
the
add-rpmlint-to-ci
branch
from
04a27f5
to
0c1cb00
Compare
KKoukiou
changed the title
|
Infrastructure check failed on these files. Please do a double check of these files before merge! Makefile.am |
|
/kickstart-tests --waive infra only |
rpmlint is used in Fedora dist git in the release process. Having it included in the upstream CI will allow us early detection of the potential linter issues in spec / rpms.