You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Follow the docs on the part of exporting games by player but is seems that since and end parameters is not working properly. I expected a subset of games filter by timestamp, instead got the max of recent games .
What I Did
start = berserk.utils.to_millis(datetime(2018, 12, 8))
end = berserk.utils.to_millis(datetime(2018, 12, 9))
games = list(client.games.export_by_player('LeelaChess', as_pgn=False, since=start, until=end,max=300))
print(len(games))
Output:
300
Reading the docs the function berserk.utils.to_millis look since and until as an int value, start and end are float. So I convert start and until to int
games = list(client.games.export_by_player('LeelaChess', as_pgn=False, since=int(start), until=int(end),max=300))
print(len(games))
Output:
291
Description
Follow the docs on the part of exporting games by player but is seems that
since
andend
parameters is not working properly. I expected a subset of games filter by timestamp, instead got themax
of recent games .What I Did
If I check the dates of the list I got:
Reading the docs the function
berserk.utils.to_millis
looksince
anduntil
as anint
value,start
andend
arefloat
. So I convertstart
anduntil
toint
And checking the dates
It's work now. I can try to fix it make a PR if you can guide me (this my first issue)
The text was updated successfully, but these errors were encountered: