Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shim 15.8 for ZeronsoftN (patch added) #433

Open
8 tasks done
joseph-zeronsoftn opened this issue Jul 30, 2024 · 4 comments
Open
8 tasks done

Shim 15.8 for ZeronsoftN (patch added) #433

joseph-zeronsoftn opened this issue Jul 30, 2024 · 4 comments
Labels
2 reviews needed Needs 2 (additional) successful reviews before being accepted Accredited review needed Needs a successful review by an accredited reviewer contacts verified OK Contact verification is complete here (or in an earlier submission)

Comments

@joseph-zeronsoftn
Copy link

Confirm the following are included in your repo, checking each box:

  • completed README.md file with the necessary information
  • shim.efi to be signed
  • public portion of your certificate(s) embedded in shim (the file passed to VENDOR_CERT_FILE)
  • binaries, for which hashes are added to vendor_db ( if you use vendor_db and have hashes allow-listed )
  • any extra patches to shim via your own git tree or as files
  • any extra patches to grub via your own git tree or as files
  • build logs
  • a Dockerfile to reproduce the build of the provided shim EFI binaries

What is the link to your tag in a repo cloned from rhboot/shim-review?


https://github.com/zeronsoftn/shim-review/tree/zeronsoftn-shim-x86_64_ia32_aarch64-20240730


What is the SHA256 hash of your final SHIM binary?


43989d3a59ff074ec9013cc000797f2139cf9fa24b30f38fee415d4daa0a41c0  shimaa64.efi
6c0c1b656c382823c9fe37110f0bf484783aa55db380664437654020fa33150b  shimia32.efi
6d47d6e3949084b7a93c4c9332ced82ad58e985ff6431e172af12072ab3d5490  shimx64.efi

What is the link to your previous shim review request (if any, otherwise N/A)?


#408


If no security contacts have changed since verification, what is the link to your request, where they've been verified (if any, otherwise N/A)?


no changed: #408

REVIEW HELPER

https://github.com/jclab-joseph/other-shim-reviews.git can help you for review.

$ git clone https://github.com/jclab-joseph/other-shim-reviews.git
$ cd other-shim-reviews
$ ./clone.sh https://github.com/zeronsoftn/shim-review/tree/zeronsoftn-shim-x86_64_ia32_aarch64-20240730
@THS-on THS-on added the blocked Blocked on upstream / other project label Jul 30, 2024
@THS-on
Copy link
Collaborator

THS-on commented Jul 30, 2024

This is currently blocked on the patches getting reviewed upstream. I'll try to ping people to have a look at it.

@THS-on THS-on added the contacts verified OK Contact verification is complete here (or in an earlier submission) label Jul 30, 2024
@steve-mcintyre
Copy link
Collaborator

@vathpela could you take a look at the patches here please?

@steve-mcintyre
Copy link
Collaborator

@vathpela ping?

@vathpela
Copy link
Contributor

I don't have a problem with any of these patches.

@steve-mcintyre steve-mcintyre added 2 reviews needed Needs 2 (additional) successful reviews before being accepted Accredited review needed Needs a successful review by an accredited reviewer and removed blocked Blocked on upstream / other project labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 reviews needed Needs 2 (additional) successful reviews before being accepted Accredited review needed Needs a successful review by an accredited reviewer contacts verified OK Contact verification is complete here (or in an earlier submission)
Projects
None yet
Development

No branches or pull requests

4 participants