You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In pkglts, this developments leads to write only normalized package names in pypi and conda dependency management files.
Nevertheless, the specification states :
The underscore is quite legal to appear in package names.
So, in other terms, pkglts forbids to use legal packages whose name contains the underscore character. But is it really the pkglts purpose to restrains the user in such a way ? This behavior change is breaking and leads to override and manually maintain the pypi and conda dependency configurations to keep using legal packages whose names contain the underscore character.
The normalization process "should be done before lookups and comparisons."
I think those cases are not in the pkglts perimeter which only factorizes and dispatches the package names supplied by the user into the pypi and conda templated dependency files. It is not up to pkglts to make operations before lookup and comparisons, but only to avoid to directly write pypi and/or conda dependency configurations. pkglts should allow all the legal package names (including not normalized ones) as long as pypi and conda allow them.
The day a package name will not be considered legal by pipy and/or conda, it is up to those tools to manage the issue, and up to the user to make the appropriate changes in the pkg_cfg.json requirement section.
In conclusion, I think we could remove the package name normalization in pipy/conda dependency management files with the best expected benefit.
The text was updated successfully, but these errors were encountered:
I suppose this dev was based on https://packaging.python.org/en/latest/specifications/name-normalization/ .
In pkglts, this developments leads to write only normalized package names in pypi and conda dependency management files.
Nevertheless, the specification states :
So, in other terms, pkglts forbids to use legal packages whose name contains the underscore character. But is it really the pkglts purpose to restrains the user in such a way ? This behavior change is breaking and leads to override and manually maintain the pypi and conda dependency configurations to keep using legal packages whose names contain the underscore character.
I think those cases are not in the pkglts perimeter which only factorizes and dispatches the package names supplied by the user into the pypi and conda templated dependency files. It is not up to pkglts to make operations before lookup and comparisons, but only to avoid to directly write pypi and/or conda dependency configurations. pkglts should allow all the legal package names (including not normalized ones) as long as pypi and conda allow them.
The day a package name will not be considered legal by pipy and/or conda, it is up to those tools to manage the issue, and up to the user to make the appropriate changes in the
pkg_cfg.json
requirement section.In conclusion, I think we could remove the package name normalization in pipy/conda dependency management files with the best expected benefit.
The text was updated successfully, but these errors were encountered: