Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package name normalisation in pkglts #240

Open
SamuelAndresPascal opened this issue Aug 17, 2024 · 0 comments
Open

Package name normalisation in pkglts #240

SamuelAndresPascal opened this issue Aug 17, 2024 · 0 comments

Comments

@SamuelAndresPascal
Copy link
Collaborator

I suppose this dev was based on https://packaging.python.org/en/latest/specifications/name-normalization/ .

In pkglts, this developments leads to write only normalized package names in pypi and conda dependency management files.

Nevertheless, the specification states :

  1. The underscore is quite legal to appear in package names.

So, in other terms, pkglts forbids to use legal packages whose name contains the underscore character. But is it really the pkglts purpose to restrains the user in such a way ? This behavior change is breaking and leads to override and manually maintain the pypi and conda dependency configurations to keep using legal packages whose names contain the underscore character.

  1. The normalization process "should be done before lookups and comparisons."

I think those cases are not in the pkglts perimeter which only factorizes and dispatches the package names supplied by the user into the pypi and conda templated dependency files. It is not up to pkglts to make operations before lookup and comparisons, but only to avoid to directly write pypi and/or conda dependency configurations. pkglts should allow all the legal package names (including not normalized ones) as long as pypi and conda allow them.

The day a package name will not be considered legal by pipy and/or conda, it is up to those tools to manage the issue, and up to the user to make the appropriate changes in the pkg_cfg.json requirement section.


In conclusion, I think we could remove the package name normalization in pipy/conda dependency management files with the best expected benefit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant