Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship core logic as a library #315

Open
jmg-duarte opened this issue Aug 15, 2024 · 1 comment · May be fixed by #322
Open

Ship core logic as a library #315

jmg-duarte opened this issue Aug 15, 2024 · 1 comment · May be fixed by #322

Comments

@jmg-duarte
Copy link

Hey there!

I love your crate and would like to try is as a simpler interface to RA as a way to test/prove an idea of mine.
To that end, I'm curious to know if you'd be interested in publishing the crate as a library.
More precisely, exposing these.

Arguably, maintenance cost doesn't change much since it's still the same code, just divided into two.
Though I understand if you don't want to open the inner interface as you'd need to keep API promises, etc.

If you're keen on having it done, I can open a PR splitting it.

@regexident
Copy link
Owner

Hi @jmg-duarte,the crate was written with the future possibility of future librarization in mind. But you're the first one to actually ask for it, so it never got done, for yagni reasons.

Feel free to open a PR. I would handle the library crate similar to rust-analyzer's library crates though: exposed inner APIs with semver-compatible release versioning but no guarantee for a stable API. Expect breakages. That said the implementation has mostly settled at this point. So those should be a rare occasion (e.g. when rust-analyzer makes a significant changes that trickle down into cargo-modules' API).

@jmg-duarte jmg-duarte linked a pull request Aug 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants