Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema validation for config #467

Open
ethanwu10 opened this issue Aug 7, 2020 · 0 comments
Open

Schema validation for config #467

ethanwu10 opened this issue Aug 7, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@ethanwu10
Copy link
Member

Is your feature request related to a problem? Please describe.
There is currently no validation of rCTF's configuration at server startup. This can result in misconfiguration going unnoticed until something else breaks later due to a bad config value.

Describe the solution you'd like
The configuration should be validated via a schema (probably with AJV since fastify uses it for route schemas). We may also want to look into specifying environment variables for config options via an extension to the schema, to reduce the boilerplate associated with parsing environment variables.

@ethanwu10 ethanwu10 added the enhancement New feature or request label Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant