RouteRandomly behavior

[Xanvial]

I'm currently checking the difference between using RouteRandomly and without (so both RouteRandomly and RouteLatency disabled)

From this line https://github.com/go-redis/redis/blob/4bda6ec2fb4a836bbffc0032ad3a0f2f79528ccb/cluster.go#L737 , it seems all nodes, including master, are considered in random checks, so for example if master node happens to be index 0 after shuffling, it will use master node, is this intended? I'm under assumption that this should only returns slave node if possible.

Also in fallback if all nodes failed in https://github.com/go-redis/redis/blob/4bda6ec2fb4a836bbffc0032ad3a0f2f79528ccb/cluster.go#L743, it just returns first randomly index. but this one is guaranteed failed (because this is checked first in for loop above this code). Alternative for this are:

• returns master node (only after master node is not considered in random selection)
• returns error, because it's Failing anyway
• keep as is
• returns random node like RouteLatency behavior, but this is the same as keeping the code as is