Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Area Item Collection Percentage goes over 100% #222

Open
dyceron opened this issue Dec 17, 2023 · 4 comments
Open

Area Item Collection Percentage goes over 100% #222

dyceron opened this issue Dec 17, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@dyceron
Copy link
Collaborator

dyceron commented Dec 17, 2023

This is because all major item locations are now counted toward the total

@dyceron dyceron added the bug Something isn't working label Dec 17, 2023
@ThanatosGit
Copy link
Collaborator

I don't even know what that means.
We don't change anything about the locations itself, we just change the actor definition it shows/uses at a location.

@duncathan
Copy link
Contributor

presumably it's for the same reasons as in dread, no?

@ThanatosGit
Copy link
Collaborator

Maybe...i don't know what is the reason in dread.

@steven11sjf
Copy link

these should be set to the max of each in custom_init
https://github.com/dyceron/MSRScripts/blob/93a2157c6a1ec79015784eb717366c7cb55a08e8/MSRScripts/romfs/system/scripts/init.lua#L23C1-L23C1

and look at what I did here for each area
https://github.com/randovania/open-dread-rando/pull/260/files#diff-4ffeac3dca7442a4452b8c1fa5c1072caf535ea5896ce731e085e2df74c83509

It'll probably be more complicated than dread since that only has one counter for all tanks. maybe poke around in lua (or save data) and see what counters exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants