Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Storybook components do not render correctly after migration #11707

Open
cnotv opened this issue Aug 26, 2024 · 5 comments · May be fixed by #12594
Open

Some Storybook components do not render correctly after migration #11707

cnotv opened this issue Aug 26, 2024 · 5 comments · May be fixed by #12594
Assignees
Labels
area/storybook area/vue3 Bugs and technical debts as outcome to the Vue3 migration kind/bug kind/tech-debt Technical debt QA/None
Milestone

Comments

@cnotv
Copy link
Contributor

cnotv commented Aug 26, 2024

Description

As by title, some components are not displayed correctly, as well as some errors are returned in some pages.

Known issues:

Screenshots

Screenshot 2024-08-26 at 16 55 17 Screenshot 2024-08-26 at 16 54 52

Screenshot 2024-09-23 at 20 10 57

@cnotv cnotv added kind/bug area/storybook area/vue3 Bugs and technical debts as outcome to the Vue3 migration labels Aug 26, 2024
@cnotv cnotv added this to the v2.10.0 milestone Aug 26, 2024
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Aug 26, 2024
@cnotv cnotv self-assigned this Aug 26, 2024
@cnotv cnotv modified the milestones: v2.10.0, v2.11.0 Oct 2, 2024
@cnotv cnotv added kind/tech-debt Technical debt QA/None kind/bug and removed kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this labels Oct 17, 2024
@cnotv
Copy link
Contributor Author

cnotv commented Oct 21, 2024

An upgrade to Storybook 8 with VueCLI/Webpack is not possible due deprecation so we should migrate to Vite asap #7468
It is not listed in the template options when creating a new object.

@cnotv
Copy link
Contributor Author

cnotv commented Oct 21, 2024

I tried to move to Storybook8 using Vite, but unfortunately, it reached a point of incompatibility.

Screenshot 2024-10-21 at 16 36 20

@cnotv
Copy link
Contributor Author

cnotv commented Oct 22, 2024

It looks like it's possible to add @storybook/vue3-webpack5 and use that instead of Vite, although it is deprecated, I repeat.

I am currently trying to port one by one the configuration. The examples are working correctly after tweaking around.

@cnotv
Copy link
Contributor Author

cnotv commented Oct 22, 2024

As a final result of my whole research about Storybook 8, it looks like it's not allowed anymore to use just MDX (flavored markdown) to document components. It is now required to first declare it as SFC (Storybook Format Component), then reference it with custom documentation if needed.

@cnotv
Copy link
Contributor Author

cnotv commented Nov 15, 2024

For some reason, the plugins are not added to the configuration with Webpack when added in preview.ts. This has been tested with a clean installation with Vue/vite (only option in CLI) and is rendered.

Installing a new version with @storybook/vue3-webpack5 restricts the issue to the library, returning an issue using documented configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/storybook area/vue3 Bugs and technical debts as outcome to the Vue3 migration kind/bug kind/tech-debt Technical debt QA/None
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants