Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport v2.9.next1] Add "v27.0.x" and "v27.1.x" options for "Docker Install URL" #11530

Closed
github-actions bot opened this issue Jul 25, 2024 · 5 comments · Fixed by rancher/ui#5158
Closed
Assignees
Labels
ember Ember UI Issue kind/enhancement QA/manual-test Indicates issue requires manually testing size/0.5 Size Estimate 0.5
Milestone

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2024

This is a backport issue for #11523, automatically created via GitHub Actions workflow initiated by @richard-cox

See rancher/rancher#46455 for dependent backend changes

Original issue body:

Is your feature request related to a problem? Please describe.
As part of rancher/rancher#46326 we're adding support for Docker 27.0.x and 27.1.x.

Describe the solution you'd like
UI dropdowns that allow picking "Docker Install URL" (e.g. on Node Template details page - not sure where else it may be referenced) should have the following new items available:

  • "v27.1.x" choice that populates https://releases.rancher.com/install-docker/27.1.sh
  • "v27.0.x" choice that populates https://releases.rancher.com/install-docker/27.0.sh

Note: Handling of default option (and addition of " (Recommended)" text) is handled via engine-install-url setting on backend that will be updated as part of rancher/rancher#46326 and should be validated on that issue.

Describe alternatives you've considered
Note "Docker Install URL" is editable and doesn't limit users to only the choices available, so they can specify other URLs manually as well before this enhancement is done.

Additional Information

See #10996 on how it was handled last time for Docker 26.1

Testing

To test, go to create a Digital Ocean cluster, click on 'Add Node Template', select a credential and click Next. Expand 'Engine Options' and verify that the new Docker Install URLs appear correctly, e.g.
image

@github-actions github-actions bot added ember Ember UI Issue kind/enhancement QA/manual-test Indicates issue requires manually testing QA/None labels Jul 25, 2024
@github-actions github-actions bot added this to the v2.9.next1 milestone Jul 25, 2024
@gaktive gaktive added the size/0.5 Size Estimate 0.5 label Jul 31, 2024
@aalves08 aalves08 self-assigned this Aug 1, 2024
@richard-cox richard-cox linked a pull request Aug 1, 2024 that will close this issue
@snasovich snasovich modified the milestones: v2.9.next1, v2.9.next2 Aug 1, 2024
@snasovich
Copy link
Contributor

@aalves08 / @richard-cox (FYI @gaktive ), we've moved rancher/rancher#46326 to v2.9-Next2 as there is a bit of testing on install-docker side and change to follow after that that will be hard to do on tight timeline we have for v2.9-Next1.
I've moved this one accordingly too but see there is already PR that got merged - and so we would like it rolled back. Thank you in advance.

@aalves08
Copy link
Member

aalves08 commented Aug 2, 2024

PR reverted @snasovich (FYI @gaktive )

@gaktive gaktive assigned nwmac and unassigned aalves08 Aug 30, 2024
@chiukapoor
Copy link

Hello Team, KDM and install-docker PRs are merged and I have drafted the PR for rancher/rancher

@chiukapoor
Copy link

@gaktive Docker v27.0.x and v27.1.x are released, https://releases.rancher.com/install-docker/27.1.sh points to 27.1.1.

@rancher-max
Copy link

rancher-max commented Sep 10, 2024

Validated using rancher v2.9-head

Version Information:

image

Previous results using Rancher v2.9.1:

image

Validation Results:

  • Both values are available, and produce the correct output
image image
  • When using them, the correct docker versions are installed:
> k get nodes -o wide
NAME      STATUS   ROLES          AGE    VERSION   INTERNAL-IP       EXTERNAL-IP   OS-IMAGE             KERNEL-VERSION       CONTAINER-RUNTIME
cp1       Ready    controlplane   175m   v1.29.8   192.168.212.162   <none>        Ubuntu 22.04.4 LTS   5.15.0-119-generic   docker://27.1.1
etcd1     Ready    etcd           175m   v1.29.8   192.168.212.107   <none>        Ubuntu 22.04.4 LTS   5.15.0-119-generic   docker://27.1.1
worker1   Ready    worker         173m   v1.29.8   192.168.212.108   <none>        Ubuntu 22.04.4 LTS   5.15.0-119-generic   docker://27.1.1
> k get nodes -o wide
NAME      STATUS   ROLES          AGE    VERSION   INTERNAL-IP       EXTERNAL-IP   OS-IMAGE             KERNEL-VERSION       CONTAINER-RUNTIME
cp2       Ready    controlplane   169m   v1.29.8   192.168.212.186   <none>        Ubuntu 22.04.4 LTS   5.15.0-119-generic   docker://27.0.3
etcd2     Ready    etcd           169m   v1.29.8   192.168.212.184   <none>        Ubuntu 22.04.4 LTS   5.15.0-119-generic   docker://27.0.3
worker2   Ready    worker         168m   v1.29.8   192.168.212.34    <none>        Ubuntu 22.04.4 LTS   5.15.0-119-generic   docker://27.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ember Ember UI Issue kind/enhancement QA/manual-test Indicates issue requires manually testing size/0.5 Size Estimate 0.5
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants