Adds refresh bank keys endpoint #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #165
This is the first step of tackling the issue that a bank updates their bank keys.
Source: https://www.hamburger-volksbank.de/firmenkunden/zahlungsverkehr/service/bankschluesselwechsel-ebics.html
It mentioned that you need to execute HPB order again when the keys are rotated.
This fix provides an endpoint that can be called so that the keys are updated.
I tested it with GLS Bank.
BEFORE calling the endpoint
direct_debits were in status failed due to 091008/EBICS_BANK_PUBKEY_UPDATE_REQUIRED - Bank key invalid
AFTER calling the endpoint
[{"at":"2021-07-29T10:01:34.176+00:00","status":"file_upload","reason":"TS01"},{"at":"2021-07-29T10:01:34.199+00:00","status":"es_verification","reason":"DS01"},{"at":"2021-07-29T10:01:34.254+00:00","status":"order_hac_final_pos","reason":""}]