-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
completing-read-multi can't select all, resets after each selection #395
Comments
A select all funcitonality doesn't exist, I think adding it to our adapted version in Selectrum is a great idea.
Hitting TAB adds another candidate to your results and you can proceed searching for more. Do you think we could do better? What behaviour are you looking for? Maybe the prompt should be selected after TAB so one can immediately exit with RET or proceed searching by typing. |
My work flow is this:
My snippet: (let ((crm-separator "|"))
(insert (string-join
(mapcar 'tsa/format-insert-email
(completing-read-multiple "Select:" (tsa/get-address-names (bbdb-records))))
", "))) |
Thanks, as far as I understand we would only need to provide a select all functionality to make this use case more convenient. The reset is intentional and for the usual case it makes sense to keep it that way unless I am missing something. Keeping the prompt selected as I mentioned earlier might still be nice. |
After trying I also see now that if you want to select multiple candidates which share a common substring the reset is inconvenient. Maybe we could have a key to add a candidate but also keep the current search string this would also solve the use case when you don't want all but multiple ones with a same substring. |
For reference the following improvements for crm could be nice:
|
These are good. An addition that would be nice is a face to highlight elements that have already been selected, so it's easily visible. |
You probably did not notice that we already omit candidates which are selected. |
Ah! Perfect! Amidst the other changes to my selection list, you're right: I didn't notice that.
|
Regarding the prompt selection I think it is better to stay consistent with how we handle it elsewhere (for example file completions). To finish your input you should press "RET" on the last candidate. If you "wrongly" typed "TAB" you can remove the last "," or select the prompt to submit. |
I used to use helm, and then ivy, to select addresses for emails I'm composing. I've now written it up using
completing-read-multiple
and at first it appears to work fine; indeed, there's no problem if I select only one. But I have problems with other major work flows:2a. Fails: Try to select all of them at once (I can't find a "select all" key in standard
completing-read-multiple
; does it exist?)2b. Press "TAB" to add one individually
How can I select all? Similarly, it seems like an undesirable workflow that hitting TAB always resets your Selectrum results.
The text was updated successfully, but these errors were encountered: