Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classic config peer discovery still might select two different seed nodes #12681

Open
dcorbacho opened this issue Nov 7, 2024 · 2 comments
Open
Labels

Comments

@dcorbacho
Copy link
Contributor

Describe the bug

Sometimes in CI the testcase peer_discovery_classic_config_SUITE:successfully_discovery fails to cluster all 7 nodes.
Six nodes join the same seed, and one other node selects itself as a seed and does not join the rest of the cluster.

The peer discovery seed selection needs to be reviewed

Reproduction steps

  1. It's a CI flake

Expected behavior

The 7 nodes join the cluster

Additional context

No response

@dcorbacho dcorbacho added the bug label Nov 7, 2024
@michaelklishin michaelklishin changed the title Peer discovery backend might fail to join the whole cluster Classic config peer discovery still might select two different seed nodes Nov 7, 2024
@michaelklishin
Copy link
Member

michaelklishin commented Nov 7, 2024

This was discussed relatively recently. Given that for this backend, the list of nodes is explicitly listed ahead of time, should we make the seed explicitly configurable, and use it in the tests?

We have tried different approaches over the years, such as "use the first node on a sorted list".

For example, Cassandra uses an explicit seed node configuration argument.

@dumbbell @mkuratczyk

@dumbbell
Copy link
Member

@dcorbacho: Do you have a link to a failing CI job or node logs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants