some bugs in function

[littlefish0331]

the "x" Arguments in function approx_distances.

"amd" should be "and"

object that can be coerced to a bounding box with bb, or a pair of coordintes
(vector of two). In the former case, the distance across the horizontal and vertical
centerlines of the bounding box are approximated. In the latter case, y is also
required; the distance between points x amd y is approximated.

object that can be coerced to a bounding box with bb, or a pair of coordintes
(vector of two). In the former case, the distance across the horizontal and vertical
centerlines of the bounding box are approximated. In the latter case, y is also
required; the distance between points x amd and y is approximated.

[littlefish0331]

Example in calc_densities.R
"women" strings are duplicate in plot

tm_shape(NLD_muni) +
tm_polygons(c("pop_women_km.2", "pop_women_km.2"),
title=expression("Population per " * km^2), style="quantile") +
tm_facets(free.scales = FALSE) +
tm_layout(panel.show = TRUE, panel.labels=c("Men", "Women"))

tm_shape(NLD_muni) +
tm_polygons(c("pop_women_km.2 pop_men_km.2", "pop_women_km.2"),
title=expression("Population per " * km^2), style="quantile") +
tm_facets(free.scales = FALSE) +
tm_layout(panel.show = TRUE, panel.labels=c("Men", "Women"))

[littlefish0331]

the following are not working right now.

I guess some need to be change usage to fit Nominatim Usage Policy

• read_osm()
• rev_geocode_OSM()
• simplify_shape()

p.s. the package is really useful for me, and help my project in many ways~
So, I point these out. Hope one day these bugs can be fixed and package become more and more better~
overall, thank you a lot!!

[mtennekes]

Thanks @littlefish0331 !

I've fixed the typos. I'm not sure how familiar you are with github, but if you are, you can make a pull request for these kind of things next time.

I've tested read_osm, rev_geocode_OSM and simplify_shape, and they work perfectly here.

• Did you use the latest github version? If not, please do.
• Did you run the document examples, or other code? If the latter is the case, please make your code reproducible and share it if possible.
• What errors did you get?
• I'm not sure if the Nominatim fair-use policy recently changed. If so, please let me know and how I can improve the code. From my point of view, it is the responsibility of the user to not overload the OSM servers.

[littlefish0331]

hi~ @mtennekes
lol~ You are right. I'm a new one in github. I'll make a pull request for this situation next time.
Thank you for spending time to response me and teach me this :)

And I use the latest version on CRAN, so maybe this is the reason. 🤣
I'll change to use github version.
Yes, I only run the Reference manual example.(still learn to use this package~)

--
I'll run all document example again in github version lately. And if there is any error I'll let you know and show my error message. 😃