Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upstream libbacktrace sources #65

Open
krlmlr opened this issue Jan 31, 2023 · 3 comments
Open

Update upstream libbacktrace sources #65

krlmlr opened this issue Jan 31, 2023 · 3 comments

Comments

@krlmlr
Copy link
Member

krlmlr commented Jan 31, 2023

Currently vendored from my fork's main branch: https://github.com/krlmlr/libbacktrace.

@krlmlr krlmlr changed the title Update upstream sources Update upstream libbacktrace sources Jan 31, 2023
@barracuda156
Copy link

macho sources are more complete here: https://github.com/ianlancetaylor/libbacktrace/blob/master/macho.c

@krlmlr
Copy link
Member Author

krlmlr commented Apr 20, 2023

Thanks. I just synced my fork, is it better now?

@barracuda156
Copy link

Apparently that is not sufficient, something else has to be fixed too. I pulled over an updated repo, but:

* checking examples ... ERROR
Running examples in ‘winch-Ex.R’ failed
The error most likely occurred in:

> ### Name: winch_trace_back
> ### Title: Native stack trace
> ### Aliases: winch_trace_back
> 
> ### ** Examples
> 
> ## Don't show: 
> if (winch_available()) (if (getRversion() >= "3.4") withAutoprint else force)({ # examplesIf
+ ## End(Don't show)
+ winch_trace_back()
+ 
+ foo <- function() {
+   winch_call(bar)
+ }
+ 
+ bar <- function() {
+   winch_trace_back()
+ }
+ 
+ foo()
+ ## Don't show: 
+ }) # examplesIf
> winch_trace_back()
Error in winch_trace_back() : unw_getcontext() error: -1073785400
Calls: <Anonymous> ... source -> withVisible -> eval -> eval -> winch_trace_back
Execution halted
* checking for unstated dependencies in ‘tests’ ... OK
* checking tests ...
  Running ‘example0.R’
 ERROR
Running the tests in ‘tests/example0.R’ failed.
Last 13 lines of output:
  > 
  > bar0 <- function() {
  +   winch_call(baz0)
  + }
  > 
  > baz0 <- function() {
  +   winch_trace_back()
  + }
  > 
  > if (winch_available()) {
  +   foo0()
  + }
  Error in winch_trace_back() : unw_getcontext() error: -1073785320
  Calls: foo0 ... <Anonymous> -> winch_call -> <Anonymous> -> winch_trace_back
  Execution halted

P. S. Updating sources is still an improvement, without that it cannot work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants