Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ncm-altlogrotate: with only the global entry, and no entries marked as global, main configfifle is not edited #1657

Open
stdweird opened this issue Feb 20, 2024 · 2 comments
Open

ncm-altlogrotate: with only the global entry, and no entries marked as global, main configfifle is not edited #1657

stdweird opened this issue Feb 20, 2024 · 2 comments

Comments

@stdweird
Copy link
Member

issue is on L139

if (@globals) { -> if (@globals || $overallglobal) {
@stdweird
Copy link
Member Author

@wdpypere this is the fix that is needed

@stdweird
Copy link
Member Author

the main issue is the logic to ensure that global is the first element in @globals, but doing an unshift to add global, and a push for the the ones with global=true should also garantee that. it's a bit odd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stdweird