_socket.py: fix for systems where AI_NUMERICSERV is not defined #3135
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3135 +/- ##
=======================================
Coverage 99.62% 99.62%
=======================================
Files 122 122
Lines 18357 18358 +1
Branches 1221 1221
=======================================
+ Hits 18289 18290 +1
Misses 47 47
Partials 21 21
|
|
@CoolCat467 That one CI which fails is unrelated, right? |
Docs are failing because your newsfragment is using markdown not rST. Try doing It's a bit confusing because the logs show two warnings, but the one you should care about is: I don't think the other one makes it fail, though I may be wrong. |
barracuda156
force-pushed
the
AI_NUMERICSERV
branch
from
641c0df
to
36a3de8
Compare
| _NUMERIC_ONLY = _stdlib_socket.AI_NUMERICHOST | _stdlib_socket.AI_NUMERICSERV | ||
| _NUMERIC_ONLY = _stdlib_socket.AI_NUMERICHOST | ||
| _NUMERIC_ONLY |= getattr(_stdlib_socket, "AI_NUMERICSERV", 0) |
There was a problem hiding this comment.
perhaps good to add a comment explaining why this is needed / when the workaround can be removed
There was a problem hiding this comment.
From the original issue, what we have learned so far is that it doesn't exist in MacOS 10.6 on PowerPC. Not sure immediately what version that changed in.
There was a problem hiding this comment.
@CoolCat467 It does not exist on any macOS on any arch before 10.6 release. In practice, this will mostly be 10.5 and 10.4, on ppc and i386. (I.e. the fix has nothing to do with the architecture, it is only dependent on SDK.)
Rationale: on some platforms
AI_NUMERICSERVmay not be defined. In particular, old versions of macOS, possibly some other. While affected users are probably few, it is a trivial fix, which makestriousable (for example,yewtubeapp works then).Credits to @CoolCat467
Closes: #3133