Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rfc3986 uses its own deprecated method - warning spam #123

Open
jpmaterial opened this issue Aug 30, 2024 · 0 comments
Open

rfc3986 uses its own deprecated method - warning spam #123

jpmaterial opened this issue Aug 30, 2024 · 0 comments

Comments

@jpmaterial
Copy link

jpmaterial commented Aug 30, 2024

In Version 2.0, in URIMixin.resolve_with() rfc3986 uses the deprecated URIReference.is_valid() instead of a Validator.

Apart from it being a bad look, it causes literally thousands of warnings in our pipeline (since resolve_with() is used often from the json-schema and jschon packages) - see below. This spams our logs and can make it hard to debug.

I made a fix: https://github.com/jpmaterial/rfc3986/tree/release/2.0 (and verified it), but there is no branch that offers itself for a pull request.

Are you interested in the fix (and releasing a 2.0.1 I guess) and if yes, on which branch should I request a pull?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant