Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dropping the execmodel concept again #150

Open
RonnyPfannschmidt opened this issue Dec 11, 2021 · 10 comments
Open

dropping the execmodel concept again #150

RonnyPfannschmidt opened this issue Dec 11, 2021 · 10 comments

Comments

@RonnyPfannschmidt
Copy link
Member

CC @ctheune @nicoddemus

the execmodel concept that @hpk42 introduced back in 2013 has multiple drawbacks

  1. it breaks execnet for testing qt, as the main thread is no longer under safe control
  2. it is completely incompatible with the async primitives that are starting to win (asyncio/trio/curio, async/await)

its not quite clear to me for what detailed use-case it was introduced, but as it is right now its a major show-stopper for me to introduce any support for modern async primitives

its the biggest reason why i dropped execnet maintenances, the second biggest reason being that there seemingly where possible placements (unfortunately the replacements turned out not to work out)

@nicoddemus
Copy link
Member

nicoddemus commented Dec 11, 2021

I think at this point we can just consider dropping anything that we don't want from execnet, given it has been in maintenance only mode, and not recommended for use in new projects, for years now.

However if we want to completely restructure execnet, we should create a new project (say execnet2), which has no backward compatibility guarantees at all (just bumping the major version to 2 is not enough as I doubt many users pin to <2).

@RonnyPfannschmidt
Copy link
Member Author

@nicoddemus thats possibly a option as well,
in that case i'd love to have a brainstorm with @ctheune about bootstrapping using wheel data + caches as well
(i recall that it coudl be a partial game changer for https://batou.readthedocs.io/en/stable/ plus i want to get away from sending code snippets, and instead adding pure python wheels to sys.path as a starting point, maybe later on adopt something extra as well

also integration with tox via @gaborbernat might be interesting, so that the tox env on the remote will use the local wheel packages, and only the actual tests sync (this would be far superior to what pytest-cloud currently does wrt rsync of virtualenvs)

@ctheune
Copy link
Contributor

ctheune commented Jan 10, 2022

@RonnyPfannschmidt thanks for inviting me to the discussion and sorry for the silence. December was a complete NOOP month for me after the whole family cought covid ... :/

On the topic: I'd be happy to join the discussion and brain storm this. I can make time next week if you like.

@RonnyPfannschmidt
Copy link
Member Author

@ctheune thanks for getting back

I hope everyone is well, it's just most unfortunate to get caught up with that

Im happy to make some time

@ctheune
Copy link
Contributor

ctheune commented Jan 17, 2022

Alright, I could do a 30 or 60 minute slot next week Monday (24th) or Friday (28th) around 9am-5pm Europe/Berlin. Does any time on those days fit for everyone else?

@RonnyPfannschmidt
Copy link
Member Author

im currently fine with a slot somewhere between earliest start at 09:00 and latest end 12:00 on both days

depending on the number of participants 30 minutes may suffice,

@ctheune
Copy link
Contributor

ctheune commented Jan 19, 2022

Lets do Friday 28th 9:00. I blocked an hour in my calendar, but I'm also happy if we get it done in 30 minutes ;)

@RonnyPfannschmidt
Copy link
Member Author

@ctheune exclent, any tool preference? else we cold just use the pytest discords voice/video channel

@ctheune
Copy link
Contributor

ctheune commented Jan 19, 2022

Happy to use either. We have a private Jitsi instance around as well. Let's try with Discord first and if that doesn't work we can fall back to Jitsi.

@ctheune
Copy link
Contributor

ctheune commented Jan 28, 2022

For everyone who wanted to attend besides @RonnyPfannschmidt and me: we have to reschedule as something personal popped up. We'll follow up here once things settle down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants