Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release notes debate #35

Open
jGaboardi opened this issue Dec 2, 2022 · 6 comments
Open

release notes debate #35

jGaboardi opened this issue Dec 2, 2022 · 6 comments

Comments

@jGaboardi
Copy link
Member

Automated release notes creation vs. gitcount.ipymb

xref this comment in pysal/libpysal#490

I have had success with the GHA for creating release notes, but we have to stay on top of adding labels to the Issues & PRs for that.

@jGaboardi
Copy link
Member Author

FWIW, I am in favor of the automated release notes action.

@jGaboardi
Copy link
Member Author

Shall I include this in #32 or wait until another PR?

@jGaboardi
Copy link
Member Author

I'll go and add it into #32.

@martinfleis
Copy link
Member

I still don't know how to ensure the up-to-date changelog.md is part of the release and rendered in the docs with a clean tag with this GHA generated notes. Is there any solution? If not it is no go for me.

@jGaboardi
Copy link
Member Author

@martinfleis That's a fair point, but is the ChangeLog that is generated on GH not enough (e.g. here), even if there isn't a specific "changelog.md" file? As for a changelog being rendered within docs, I am not aware that it is/was being done anywhere within the PySAL ecosystem besides in momepy (but maybe I'm wrong?).

@martinfleis
Copy link
Member

As for a changelog being rendered within docs, I am not aware that it is/was being done anywhere within the PySAL ecosystem

That is possible but it is imo a good practice to have in the docs as well. If you look at any major project, there always some form of it in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants