Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focus ring on Sphinx Design dropdowns missing again #1923

Open
gabalafou opened this issue Jul 11, 2024 · 1 comment · May be fixed by #1986
Open

Focus ring on Sphinx Design dropdowns missing again #1923

gabalafou opened this issue Jul 11, 2024 · 1 comment · May be fixed by #1986
Assignees
@gabalafou
Labels
needs: investigation Someone in the team needs to investigate and try and reproduce this issue tag: accessibility Issues related to accessibility issues or efforts

Comments

@gabalafou
Copy link
Collaborator

Did we recently update Sphinx Design and did Sphinx Design update their CSS in such a way that the outline: none rule that I'm seeing in the Sphinx Design stylesheet loaded in our docs is now superseding our own CSS?

Steps to reproduce:

  1. Visit dropdowns in the docs
  2. Click or double click on the heading "Dropdowns"
  3. Press tab key repeatedly
  4. You should see a focus ring move from the anchor hash (#) to the paragraph link, but then disappear for several tab key presses (6 precisely) before it reappears on the link in the paragraph under "Copybuttons" heading.
@gabalafou gabalafou self-assigned this Jul 11, 2024
@trallard trallard added tag: accessibility Issues related to accessibility issues or efforts needs: investigation Someone in the team needs to investigate and try and reproduce this issue labels Jul 11, 2024
@gabalafou
Copy link
Collaborator Author

@trallard checked and the latest release from SD indeed added an outline: none to the dropdown details

This was referenced Oct 17, 2024
Open
Open
@gabalafou gabalafou mentioned this issue Oct 31, 2024
Open
@gabalafou gabalafou mentioned this issue Nov 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gabalafou gabalafou

Labels
needs: investigation Someone in the team needs to investigate and try and reproduce this issue tag: accessibility Issues related to accessibility issues or efforts
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make hover effect on dropdown admonitions more prominent gabalafou/pydata-sphinx-theme
2 participants
@gabalafou @trallard