Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for AlloyDB #918

Open
geekflyer opened this issue Aug 24, 2023 · 6 comments
Open

Add Support for AlloyDB #918

geekflyer opened this issue Aug 24, 2023 · 6 comments
Labels
kind/enhancement Improvements or new features

Comments

@geekflyer
Copy link

geekflyer commented Aug 24, 2023

Hi,

currently seems like AlloyDB isn't supported (which is a new API namespace).
It's already supported in the classic provider: https://www.pulumi.com/registry/packages/gcp/api-docs/alloydb/cluster/

Can we please add to the native provider?

The classic / tf provider doesn't expose certain backup options like continuous backup, so I'd like to use the native one instead.

Best, Christian

@geekflyer geekflyer added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Aug 24, 2023
@ringods
Copy link
Member

ringods commented Aug 24, 2023

Hello @geekflyer, this native provider is generated from Google specs returned from the Discovery API:

resp, err := http.Get("https://discovery.googleapis.com/discovery/v1/apis?parameters")

I pulled the latest contents from this endpoint, but the result doesn't contain any reference to alloydb resources. This means we can't support AlloyDB for now.

@ringods
Copy link
Member

ringods commented Aug 24, 2023

Support for continuous backup is added in TF provider v4.78.0, which is included in our GCP Classic provider v6.64.0

@danielrbradley danielrbradley added resolution/by-design This issue won't be fixed because the functionality is working as designed and removed needs-triage Needs attention from the triage team labels Aug 25, 2023
@danielrbradley
Copy link
Member

Thanks for the investigation @ringods

I'm going to close this as it appears the specifications haven't been made available for discovery yet. As soon as they are, this should be automatically included and shouldn't require any action on our part.

@mikhailshilkov
Copy link
Member

Discovery documents are available in https://alloydb.googleapis.com/$discovery/rest?version=v1

@danielrbradley I don't think we should close the issue until we ship the feature. We should mark it as awaiting-upstream if it's blocked.

@mikhailshilkov mikhailshilkov removed the resolution/by-design This issue won't be fixed because the functionality is working as designed label Aug 25, 2023
@geekflyer
Copy link
Author

geekflyer commented Aug 25, 2023

I reached out to our GCP account team to see why this is not in the central discovery API yet and get its inclusion prioritized fyi.

@lukehoban
Copy link
Member

This is now fixed by GCP - the discovery doc is now available at https://discovery.googleapis.com/discovery/v1/apis?name=alloydb. The next release of this provider should pick up these APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

5 participants