Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce conditional delete before replace for select resources #2596

Open
t0yv0 opened this issue Nov 8, 2024 · 2 comments
Open

Introduce conditional delete before replace for select resources #2596

t0yv0 opened this issue Nov 8, 2024 · 2 comments
Labels
awaiting/bridge The issue cannot be resolved without action in pulumi-terraform-bridge. blocked The issue cannot be resolved without 3rd party action. kind/enhancement Improvements or new features

Comments

@t0yv0
Copy link
Member

t0yv0 commented Nov 8, 2024

Consider introducing conditional delete-before-replace plans that would suggest to that Pulumi should delete first, and create later when replacing a resource when particular sensitive properties change.

Affected resources:

  • google_compute_global_address
  • google_compute_instance
  • google_compute_vpn_tunnel
  • google_project_iam_member
  • google_service_account_iam_member

We tried enabling delete-before-replace as the default strategy for these resources but decided to revert his behavior as it may not be appropriate for all users, for example for the compute instance resource, delete-before-replace may reduce liveness/availability and are not ideal for every update, see:

Instead of doing that, the suggestion is to identify the specific properties that require this treatment, build the bridge support so allow specifying this behavior per-property, and rolling forward:

pulumi/pulumi-terraform-bridge#2605

References

#73
#190

@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Nov 8, 2024
@VenelinMartinov
Copy link
Contributor

Do we know if all of these resource require a Conditional DeleteBeforeReplace? Would some of them be fine with unconditional DBR?

@t0yv0
Copy link
Member Author

t0yv0 commented Nov 8, 2024

The task includes investigating which properties or resource-wide DBR is appropriate for each of these.

@rshade rshade added blocked The issue cannot be resolved without 3rd party action. awaiting/bridge The issue cannot be resolved without action in pulumi-terraform-bridge. and removed needs-triage Needs attention from the triage team labels Nov 8, 2024
t0yv0 added a commit that referenced this issue Nov 8, 2024
Context:

#2596

Revert:

- #2586
- #2588

Affected resources:

- google_compute_global_address
- google_compute_instance
- google_compute_vpn_tunnel
- google_project_iam_member
- google_service_account_iam_member
@mikhailshilkov mikhailshilkov added the kind/enhancement Improvements or new features label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting/bridge The issue cannot be resolved without action in pulumi-terraform-bridge. blocked The issue cannot be resolved without 3rd party action. kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

5 participants