Fix empty labels handling in Cluster resource #2441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VenelinMartinov
requested review from
t0yv0,
guineveresaenger,
iwahbe and
a team
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
iwahbe
approved these changes
Sep 25, 2024
VenelinMartinov
added
the
needs-release/patch
|
@iwahbe I've removed the recorded initial preview output as it seems to be non-deterministic and not strictly necessary for the regression test: https://github.com/pulumi/pulumi-gcp/actions/runs/11036213803/job/30655036675 |
|
This PR has been shipped in release v8.3.1. |
github-actions
bot
removed
the
needs-release/patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the empty label handling in the GCP Cluster resource.
In the fix for #2372 (#2386 and pulumi/pulumi-terraform-bridge#2417) we did not know that the labels property in GCP is sometimes overloaded, ex GCP Custer.
For the Cluster resource, the GCP labels are under
resource_labels, notlabelsThis PR adds the logic to the empty labels fix and adds a regression test.
fixes #2395