Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "unable to detect a global setting for GCP Project" warning. #1168

Open
shadiramadan opened this issue Aug 26, 2023 · 3 comments
Open
Labels
area/providers impact/reliability Something that feels unreliable or flaky kind/enhancement Improvements or new features

Comments

@shadiramadan
Copy link

msg := "unable to detect a global setting for GCP Project;\n" +

I have pulumi configuration which creates GCP projects (thus no global project ID is set) and I've found this warning very annoying in my outputs.

Could we remove or supress this specific warning?

@mikhailshilkov mikhailshilkov added the needs-triage Needs attention from the triage team label Aug 28, 2023
@iwahbe iwahbe added kind/bug Some behavior is incorrect or out of spec kind/enhancement Improvements or new features impact/reliability Something that feels unreliable or flaky area/providers and removed kind/bug Some behavior is incorrect or out of spec labels Aug 28, 2023
@iwahbe
Copy link
Member

iwahbe commented Aug 28, 2023

Hi @shadiramadan. Thanks for telling us about the issue. I agree that the warning should be addressable. Looks like the warning was put in to address #890.

@guineveresaenger
Copy link
Contributor

Per discussion with @iwahbe:

We believe we can implement this in the following way:

  1. When the warning first appears, we can allow/instruct the user to explicitly bypass it via explicitly setting gcp:project to something like "No Project" or any other string that is invalid to use for GCP Projects and thus not a potential Project name.
  2. We then look for this value in our pre-config check and set Project to a pulumi-internal constant.
  3. When this constant is detected on a stack, we know the user does not need the warning, and skip it.
  4. We will adjust the warning text to include override instructions.

@iwahbe iwahbe removed the needs-triage Needs attention from the triage team label Aug 28, 2023
@SpainTrain
Copy link

Curious whether there is any progress on this?

Configurable warnings (generally, and specific to this) are very helpful for better DX. In our case developers think they are doing something wrong when they interact with our stacks because we do not use the default project feature. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/providers impact/reliability Something that feels unreliable or flaky kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

5 participants