Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeGroup & NodeGroupV2 input property instanceProfile should accept Input type #1489

Open
flostadler opened this issue Nov 13, 2024 · 0 comments
Labels
impact/breaking Fixing this issue will require a breaking change impact/usability Something that impacts users' ability to use the product easily and intuitively kind/enhancement Improvements or new features

Comments

@flostadler
Copy link
Contributor

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

Right now, the instanceProfile input property of NodeGroup & NodeGroupV2 only accepts plain instance profile resources (aws.iam.InstanceProfile).

The implementation of the two node group components does not constrain this input property to be plain though, they can be of Input type.

Changing this is a breaking change though. It would affect the Golang SDK.

Affected area/feature

  • instanceProfile input property of NodeGroup & NodeGroupV2
@flostadler flostadler added impact/usability Something that impacts users' ability to use the product easily and intuitively kind/enhancement Improvements or new features needs-triage Needs attention from the triage team impact/breaking Fixing this issue will require a breaking change and removed needs-triage Needs attention from the triage team labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/breaking Fixing this issue will require a breaking change impact/usability Something that impacts users' ability to use the product easily and intuitively kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

1 participant