Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose docker build context digest that is used to determine whether to do docker build or not. #872

Open
efrench-novi opened this issue Dec 6, 2023 · 1 comment
Labels
impact/usability Something that impacts users' ability to use the product easily and intuitively kind/enhancement Improvements or new features

Comments

@efrench-novi
Copy link

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

Currently, the docker Image resource will only build if the build context changes, which is a nice feature that allows skipping unnecessary builds. However, we are currently tagging our images with the git SHA, which forces a new build and image deployment on every commit. This results in deploying all image based resources (Service, Batch jobs, lambdas, etc), even though it is unnecessary.

We would like to be able to tag the image with the value of the build context digest so image dependent resources are only updated when a new image is built (and no other resource changes are made). This will allow for well behaved projects that only build and deploy images when necessary, and only deploy image based resources when the image itself changes.

Affected area/feature

@efrench-novi efrench-novi added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Dec 6, 2023
@mjeffryes
Copy link
Member

That sounds reasonable; I'll add this to our backlog.

@mjeffryes mjeffryes added impact/usability Something that impacts users' ability to use the product easily and intuitively and removed needs-triage Needs attention from the triage team labels Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/usability Something that impacts users' ability to use the product easily and intuitively kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

2 participants