Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update awsx to use docker-build #1349

Open
mjeffryes opened this issue Jul 22, 2024 · 5 comments · May be fixed by #1278
Open

Update awsx to use docker-build #1349

mjeffryes opened this issue Jul 22, 2024 · 5 comments · May be fixed by #1278
Assignees
Labels
kind/task Work that's part of an ongoing epic

Comments

@mjeffryes
Copy link
Member

docker-build is build is now the recommended way to build docker images, so we need to update the AWSX components to use it.

@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Jul 22, 2024
@t0yv0 t0yv0 removed the needs-triage Needs attention from the triage team label Jul 23, 2024
@mjeffryes mjeffryes added this to the 0.108 milestone Jul 24, 2024
@flostadler
Copy link
Contributor

I'd like to propose a different option here. Instead of adding the different docker resources, why don't we add a function/resource method to create the provider/auth data instead?

The existing Image resource is mostly just configuring auth: https://github.com/pulumi/pulumi-awsx/blob/44d871d77778c9c5cad7b0e421a37b4153692bc9/awsx/ecr/image.ts

@danielrbradley
Copy link
Member

Yes I think this is a great idea. This gives users much more composable blocks to build from.

Option 1: Include the credentials as an output of the registry resource in awsx - an object containing registry, username & password properties. These must be marked as secrets.

Option 2: Create an invoke which returns the same properties. This could live in either aws or awsx.

Perhaps we do both?

@iwahbe
Copy link
Member

iwahbe commented Aug 9, 2024

This sounds like a great idea!

@blampe blampe linked a pull request Aug 9, 2024 that will close this issue
@blampe
Copy link
Contributor

blampe commented Aug 9, 2024

@flostadler to clarify, we aren't adding any new resources only changing the internals of what's currently available. The legacy docker provider is showing its age, and it would be good to prevent issues like e.g. pulumi/pulumi-docker#967 (comment) from biting the user.

I agree that auth helpers would also be a great cohesive addition.

@j-fulbright
Copy link

Any ideas on when this make it out into production? We'd like to be able to use docker this way instead of having to make config changes

@mjeffryes mjeffryes removed this from the 0.108 milestone Aug 19, 2024
@mjeffryes mjeffryes added the kind/task Work that's part of an ongoing epic label Aug 23, 2024
@mjeffryes mjeffryes added this to the 0.110 milestone Sep 12, 2024
@mjeffryes mjeffryes modified the milestones: 0.110, 0.111 Oct 2, 2024
@mjeffryes mjeffryes removed this from the 0.111 milestone Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Work that's part of an ongoing epic
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants