Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate possible improvements to the implementations of manifest fields #1803

Open
git-hyagi opened this issue Oct 31, 2024 · 0 comments
Open

Investigate possible improvements to the implementations of manifest fields #1803

git-hyagi opened this issue Oct 31, 2024 · 0 comments
Labels
Task

Comments

@git-hyagi
Copy link
Contributor

git-hyagi commented Oct 31, 2024 •
edited
Loading

This is a follow-up of review comments:
#1782 (comment)
#1782 (comment)

We could investigate the feasibility of the suggested improvements:

  • merge the os/arch/size/metadata manifest methods to prevent incorrect updates of these fields
  • verify if a dataclass together with asdict would be helpful for the manifest fields defined from platform
@git-hyagi git-hyagi added the Task label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@git-hyagi