Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert all tests to pytest style #715

Open
decko opened this issue Nov 28, 2022 · 2 comments
Open

Convert all tests to pytest style #715

decko opened this issue Nov 28, 2022 · 2 comments

Comments

@decko
Copy link
Member

decko commented Nov 28, 2022

Any attempt to create a new plugin should already use the pytest style for tests.
This could avoid any after rework converting tests.

@lubosmj
Copy link
Member

lubosmj commented Nov 29, 2022

It would be worth discussing whether those tests need to be maintained at all. As a plugin writer, I had to rewrite them from scratch. The tests are here as a reminder for plugin writers to ensure they do not forget to write tests. They are not executable by default. Have we considered removing them? We would only leave an empty dir tree there (with one empty file -> test_nothing.py).

@ggainey
Copy link
Contributor

ggainey commented Nov 29, 2022

I think having at least one example of "this is how to write tests" is useful for a new plugin author, fwiw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants