Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolver issues #13

Open
puff opened this issue Jun 20, 2023 · 0 comments · May be fixed by #22
Open

Resolver issues #13

puff opened this issue Jun 20, 2023 · 0 comments · May be fixed by #22
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@puff
Copy link
Owner

puff commented Jun 20, 2023

The resolver is slow, fails to handle some types, and is hard to read and navigate. It has problems with nested types and types/methods using generics in particular.

It would be good to completely rewrite it. There are many useful helpers in AsmResolver that could be utilized like TypeNameParser, SignatureComparer, GenericContext, TypeDescriptorExtensions.

VMInlineOperandData may also need to be rewritten. Having it recursively read the data of each VMInlineOperand property in it (DeclaringType, GenericArguments, etc) would be helpful, especially when resolving methods utilizing type generics.

@puff puff added bug Something isn't working enhancement New feature or request labels Jun 20, 2023
@puff puff changed the title Rewrite Resolver Resolver issues Jun 20, 2023
@puff puff self-assigned this Jun 20, 2023
@puff puff linked a pull request Nov 5, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant