Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor data revalidation #200

Open
gratestas opened this issue Jun 16, 2023 · 0 comments
Open

Refactor data revalidation #200

gratestas opened this issue Jun 16, 2023 · 0 comments
Labels
priority: high it needs to be prioritized over issue which does not have any priority labels type: enhancement New feature or request

Comments

@gratestas
Copy link
Member

gratestas commented Jun 16, 2023

Due to a recent react-router-specific upgrade #171 , some nested components down the routes can't perform automatic data revalidation.

  1. In some components, we do it manually using the useRevalidator hook in case of an HTTP request. Ideally, data should be revalidated automatically making use of the router's action APIs. Consider accomplishing this.
  2. Some components may not explicitly handle data revalidation in response to user interaction. For example, in the VotingPeriod component data mutation (e.g. castVote() ) is being triggered outside the app. Data fetching is happening in Router's loader on the corresponding route during the page load only.
- Article (route)
    |__ArbitrationDetails
         |__VotingPeriod

In such a case, we may need to perform the data revalidation for a route manually

@gratestas gratestas added priority: high it needs to be prioritized over issue which does not have any priority labels type: enhancement New feature or request labels Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high it needs to be prioritized over issue which does not have any priority labels type: enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

1 participant