Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

BeginTx: spec for contract creation via Tx #420

Closed
ed255 opened this issue May 12, 2023 · 0 comments · Fixed by #433
Closed

BeginTx: spec for contract creation via Tx #420

ed255 opened this issue May 12, 2023 · 0 comments · Fixed by #433
Assignees

Comments

@ed255
Copy link
Member

ed255 commented May 12, 2023

Recently we merged the spec for CREATE/CREATE2: #355
But I noticed that the spec for contract creation via Tx is not done:

if tx_is_create == 1:
# TODO: Verify created address
# code_hash represents the contract creation code
# 1. In the case of root call, code_hash is the hash of the tx calldata.
# 2. In the case of internal call, code_hash is the hash of the chunk of
# caller memory corresponding to the contract init code.
raise NotImplementedError

Nevertheless on the circuit side this seems to be implemented:
https://github.com/privacy-scaling-explorations/zkevm-circuits/blob/0e1d230191d3a1b3ea4b27034c73a545a6e66158/zkevm-circuits/src/evm_circuit/execution/begin_tx.rs#L212-L295

So we need to sync the specs on the create case of BeginTx.

@KimiWu123 KimiWu123 assigned KimiWu123 and unassigned KimiWu123 May 15, 2023
@KimiWu123 KimiWu123 moved this to 📋 Refined Backlog in zkEVM Community Edition May 16, 2023
@ChihChengLiang ChihChengLiang moved this from 📋 Sprint Focus to Milestone Tasks in zkEVM Community Edition May 18, 2023
@ed255 ed255 moved this from Milestone Tasks to 📋 Sprint Focus in zkEVM Community Edition Jun 1, 2023
@adria0 adria0 moved this from 📋 Sprint Focus to 🏗 In progress in zkEVM Community Edition Jun 2, 2023
@adria0 adria0 linked a pull request Jun 14, 2023 that will close this issue
@ChihChengLiang ChihChengLiang moved this from 🏗 In progress to 👀 In review in zkEVM Community Edition Jun 20, 2023
@ChihChengLiang ChihChengLiang moved this from 👀 In review to ✅ Done in zkEVM Community Edition Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants