-
Notifications
You must be signed in to change notification settings - Fork 104
Built-in Player Issues #30
Comments
It works! I need speed and silence skip controls though. |
@barolo it currently only plays files downloaded through NewPipe because the files shown in that view are based on their respective entries in the database. It's not really a file-browser more like a list of files NewPipe already knows about. |
I know :) I was just asking if there's a plan to change, extend that. There's no need really because as I said previously AntennaPod gives me that functionality |
It would be amazing if the local player would have the same look and behaviour as "online" player, with brightness and volume swipe gestures… |
@B0pol yup! The goal is to make the built-in local player match the normal player, but unfortunately it isn't an easy thing to do. For now I'm essentially re-building the player from scratch to figure out how "tightly-bound" the normal player is to the online functionality. Eventually I (or maybe someone smarter than me) will figure out how to isolate the normal player and it's features from the rest of NewPipe's infrastructure. |
I don't know if it is possible to see timestamps and chapters within the downloaded videos. If not, there should be sn option to download all video information within app and make Newpipe a media player for other media files in the device as well. Please remember that all timestamps aren't counted as chapters as all of them don't start from 0:00. Add ability to access all timestamps from chapters button. And, yes, following related features should be included. I thought these changes should be brought at the same time. So, I included them in the same issue.
|
Jesus |
@SameenAhnaf thanks for the suggestions, though I can tell you for sure I do not plan on implementing items 1, 2, 4, 5, 6, 7, 10, 11, 14, 15, nor 16. If someone else wants to do those by all means go for it - submit a pull request and I will see how easy they can be to merge in. For now, I'm just focusing on having the built-in local player match the abilities of the normal player (for clarity, I'm talking about the player itself, not things like comments, video info, etc). |
@polymorphicshade love the fact that you have implemented a built-in player to this fork and would like to suggest a couple of features that I think would be great.
I didn't know if I should put this here or open a new request/issue but anyway, thanks for your amazing work Polymorphicshade! |
@JustyB76 yep this is the right spot to post feedback about the built-in local player. Good suggestions there. Once I figure out how to use NewPipe's notification service with this particular player, implementing those suggestions should be easy to do. |
Love the built-in player and the fact that it continues playing with the screen off. This feature should definitely be promoted/mentioned in the readme. Personally I miss two things:
|
Can i just export the video without segments? I suppose you can just add ffmpeg binary and run the cut command with the relevent segments. If adding ffmpeg seems like an overkill can you just output ffmpeg command in a textbox? I will just run it in termux. |
@polymorphicshade thanks 👍 for this great apk... The additionally important features i think local player should haveWell there are some important features i want to point out...
Well I think these are only features the player should really really have... |
As of release 0.20.9 w/ SponsorBlock, this app now comes with the addition of a built-in local playback feature with SponsorBlock support.
To use this feature, go to: Settings -> Extras -> Enable Local Player (alpha)
Please report any issues you have with the player here, as I'm sure there will be plenty.
If you would like to enable SponsorBlock segments for your already existing downloads, you must re-download them. This is because of the database updates I made to support a new column with SponsorBlock segment data.
Some planned additions for the built-in player:
The text was updated successfully, but these errors were encountered: