Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signing and verifying a message using ECDSA sometimes fails #1898

Open
4 of 10 tasks
rjwebb opened this issue Nov 22, 2023 · 1 comment
Open
4 of 10 tasks

Signing and verifying a message using ECDSA sometimes fails #1898

rjwebb opened this issue Nov 22, 2023 · 1 comment
Labels
Bug Tracks issues causing errors or unintended behavior, critical to fix for reliability. Help Wanted Tasks open for external contributions, suitable for independent or collaborative work. P1 - High Essential for progress, blocks other tasks. Must be completed soon to maintain project flow.

Comments

@rjwebb
Copy link

rjwebb commented Nov 22, 2023

  • I'm submitting a ...

    • Bug report
    • Feature request
    • Support request
    • Other
  • What is the current behavior and expected behavior?

Expected behaviour: I should be able to generate a KeyringPair that signs messages using the ECDSA algorithm and verify the signatures against the message + the KeyringPair's public key

Current behaviour: This works most of the time, approx 99/100 times, but sometimes the verification fails.

  • What is the motivation for changing the behavior?

I'm working on a project that relies on being able to sign and verify data from the KeyringPair or from Polkadot wallets so I want to be able to rely on this functionality.

  • Please tell us about your environment:

I'm using @polkadot/keyring, @polkadot/util and @polkadot/util-crypto at the latest version as of writing (12.6.1).

I've created a minimal repository here that reproduces the bug: https://github.com/rjwebb/polkadot-ecdsa-bug-reproduction

  • Version: 12.6.1

  • Environment: Node v18.17.1

    • Node.js
    • Browser
    • Other (limited support for other environments)
  • Language:

    • JavaScript
    • TypeScript (include tsc --version) 5.2.2
    • Other
@TarikGul TarikGul added Bug Tracks issues causing errors or unintended behavior, critical to fix for reliability. P1 - High Essential for progress, blocks other tasks. Must be completed soon to maintain project flow. labels Oct 28, 2024
@TarikGul
Copy link
Member

Thanks for the reproduction, I was able to reproduce it. Added to the project board as High, and putting a Help wanted tag on it to hopefully garner a little bit of attention. If bandwidth frees up I will investigate this further.

@TarikGul TarikGul added the Help Wanted Tasks open for external contributions, suitable for independent or collaborative work. label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Tracks issues causing errors or unintended behavior, critical to fix for reliability. Help Wanted Tasks open for external contributions, suitable for independent or collaborative work. P1 - High Essential for progress, blocks other tasks. Must be completed soon to maintain project flow.
Projects
Development

No branches or pull requests

2 participants