api-contracts: handle foreign events gracefully

[peetzweg]

During the adaption of the event decoding for smart contract for ink! v5, #5791, it became clear that the prior and current implementation can't handle all circumstances gracefully.

The current implementation supports:

• decoding of events emitted by the called contract for ink v4 and prior,
• decoding of events emitted by the called contract for new events 2.0 in ink v5,
• decoding anonymous events emitted by the called contract, if the anonymous event can be determined (single possibility, which event it could have been), otherwise it throws an error.

What could be improved:

• handle inability to determine anonymous event more gracefully by not decoding it and just returning bytes. The overall flow of how the decoding is done, does not allow for this now afaik.

Another usecase for this feature would be in handling foreign events. Foreign events are events emitted by the called contract but are defined in a different contract which was invoked by the called contract. For what I know this case of decoding events from a contract which ABI we don't have is not handled and will result in errors being thrown.

More information about this behavior you can find here:

• https://use.ink/5.x/basics/cross-contract-calling
• feat: ink! v5 #5791 (comment)

[tad3j]

Could #5791 be responsible for this error?
Expected Option<*> definition for accountId in ContractEnvironment
I started getting this today with this new version but it works in old one so it seems like a breaking change?

[peetzweg]

@tad3j Feels unlikely to me but not impossible. Could you share some code and steps to reproduce this? In which context is this happening?

[tad3j]

It's failing on line marked bellow (old version of code) when parsing this abi.

Code:

const contract = new PinkContractPromise(
      this.api,
      this.registry,
      contractAbi,
      contractAddress,
      contractKey,
    );
const keyring = new Keyring({ type: 'sr25519' });
const account = keyring.addFromUri('//Alice');
const certificate = await signCertificate({ api: this.api, pair: account });
onst response = await contract.query.encryptContent(
      account.address,
      {
        cert: certificate,
      },
      content,
    );
return response.output.toJSON()['ok'].ok;

[peetzweg]

@tad3j I was able to instantiate a ContractPromise instance without a problem with the latest pjs version.

Here is my code:

import { ApiPromise, WsProvider } from "@polkadot/api";
import { ContractPromise } from "@polkadot/api-contract";
import abi from "./abi.json";

const wsProvider = new WsProvider(`wss://rococo-contracts-rpc.polkadot.io`);
const api = await ApiPromise.create({
  provider: wsProvider,
});
const address = "5EnufwqqxnkWT6hc1LgjYWQGUsqQCtcr5192K2HuQJtRJgCi";

try {
  const contract = new ContractPromise(api, abi, address);
  console.log({ environment: contract.abi.environment });
} catch (error) {
  console.error("Initializing contract error", error);
}

process.exit(0);

You could run it by i.e npx tsx abi.ts

Not sure what the PinkContractPromise is about in your code. Maybe you are using some sort of wrapper library?

[tad3j]

Strange, maybe it's issue with Phala SDK...will check.

Locking to "@polkadot/types": "10.11.3", (version we used before) fixes the issue.

[peetzweg]

@tad3j can you share which sdk you are using? Sounds reasonable that it might cause issues with sdks building ontop of pjs. They have probably not yet upgraded their sdk and this could cause hiccups.

[tad3j]

I'm using @phala/sdk. They've said they dont support ink v5 so maybe that's why it didn't work.

EDIT: I've completely removed phala but TX signing is still failing.