Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokens: Drop Email #916

Open
lautarodragan opened this issue Apr 14, 2019 · 3 comments
Open

Tokens: Drop Email #916

lautarodragan opened this issue Apr 14, 2019 · 3 comments

Comments

@lautarodragan
Copy link
Member

No description provided.

@lautarodragan
Copy link
Member Author

This may break stuff in Explorer. Needs research.

@lautarodragan lautarodragan changed the title Stop Adding Email to Tokens Tokens: Drop Email Apr 14, 2019
@lautarodragan
Copy link
Member Author

Alternatively we may be able to keep the email in the token and ignore it.

const { client_token, email } = decoded as any
const tokenData = await Vault.verifyToken(client_token)
const usersController = new AccountsController(ctx.logger, verifiedAccount, pwnedCheckerRoot)
ctx.state.tokenData = tokenData
ctx.state.user = await usersController.get(email)

But it's also duplicated information which could be outdated and cause strange issues.

@lautarodragan
Copy link
Member Author

lautarodragan commented Jun 12, 2019

The only remaining thing blocking this issue is letting the users know their API Keys will become obsolete and that they need to create new ones and use those instead.

Once that is done and this task is implemented, PATCH /accounts/:id { email: '[email protected]' } will work as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant