Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable keyboard navigation for stats tabs by converting list elements to button elements #2526

Merged

Conversation

djanda97
Copy link
Contributor

Fixes #2338

Changes

Enable keyboard navigation for stats tabs by converting list elements to button elements

Tests

  • This PR does not require tests

Changelog

  • This PR does not make a user-facing change

Documentation

  • This change does not need a documentation update

Dark mode

  • This PR does not change the UI

@ukutaht
Copy link
Contributor

ukutaht commented Jan 5, 2023

Tested on my own machine and tab navigation does work with no changes to the UI. Thanks @djanda97!

@bundlemon
Copy link

bundlemon bot commented Jan 5, 2023

BundleMon

Files updated (1)
Status Path Size Limits
static/js/dashboard.js
297.98KB (+545B +0.18%) -
Unchanged files (6)
Status Path Size Limits
static/css/app.css
515.19KB -
static/js/app.js
12.13KB -
static/js/embed.host.js
5.58KB -
static/js/embed.content.js
5.06KB -
tracker/js/plausible.js
748B -
static/js/applyTheme.js
314B -

Total files change +545B +0.06%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@ukutaht ukutaht merged commit f949278 into plausible:master Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A11y: Keyboard navigation not possible on a section tabs
2 participants