Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1 #25

Open
djmitche opened this issue Dec 2, 2020 · 5 comments
Open

Release v1 #25

djmitche opened this issue Dec 2, 2020 · 5 comments

Comments

@djmitche
Copy link

djmitche commented Dec 2, 2020

I see you've switched to go modules by adding go.mod. Could you now release a semver-formatted version of this library? I think that's as easy as git tag v1.0.0 and pushing.

@luna-duclos
Copy link
Collaborator

I just took over maintainership of this project, so I'm not quite comfortable doing this just yet, but if things go well I might check with Dave Chenney eventually to do this.

I'll leave this hanging for a while.

@djmitche
Copy link
Author

djmitche commented Dec 9, 2020

Sounds good. The downside of not doing semantic versioning is that every commit to main is a "release", so the pressure's a bit higher to make sure you're right every time you click "Merge PR" than it would be with semantic versioning. And it also means that every such click triggers things like dependabot and renovate to file PRs for downstream libraries.

@telegrapher
Copy link

Hello!

I think that tagging a 1.0.0 may need a bit of planning, because if you follow semver, you're establishing a stable API.

But to start tagging 0.x.x releases shouldn't be problematic, since there is no commit to a stable API, and our go.mod files will be way nicer :)

@djmitche
Copy link
Author

In a practical sense, I don't know if there's a difference. If 0.1.2 breaks API compat with 0.1.1, that's just as disruptive as v2 breaking with v1, if not a bit worse since automated systems can't tell that it's a breaking change.

My advice is, don't be afraid of breaking changes. The app I work on day-to-day is at v41. It's just a clear signal to your users :)

@davecheney
Copy link
Member

I don't expect the library to be v1 ready any time soon. sorry. I'd prefer not to do the v1, v2, v44 game as it serves little utility and adds the overhead of the go modules v2 nonsense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants